Skip to content

fix(BuilderBlock): include custom attributes in canvas#508

Merged
surajshetty3416 merged 2 commits intofrappe:developfrom
stravo1:custom-attribs-on-canvas-block
Mar 6, 2026
Merged

fix(BuilderBlock): include custom attributes in canvas#508
surajshetty3416 merged 2 commits intofrappe:developfrom
stravo1:custom-attribs-on-canvas-block

Conversation

@stravo1
Copy link
Copy Markdown
Member

@stravo1 stravo1 commented Mar 4, 2026

HTML Attributes were attached to elements only after rendering in Preview or after Publishing. Now they are attached to BuilderBlocks in the Canvas as well. This fixes Client Script executions on Canvas (both Page and Block level) which make use of these attributes.

@stravo1 stravo1 requested a review from surajshetty3416 March 4, 2026 12:08
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.58%. Comparing base (1f2ecd8) to head (2ca162b).
⚠️ Report is 107 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #508      +/-   ##
===========================================
+ Coverage    63.01%   63.58%   +0.56%     
===========================================
  Files           28       28              
  Lines         2739     2779      +40     
===========================================
+ Hits          1726     1767      +41     
+ Misses        1013     1012       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stravo1 stravo1 requested a review from surajshetty3416 March 6, 2026 02:29
@surajshetty3416 surajshetty3416 merged commit 0700385 into frappe:develop Mar 6, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants