fix(TypographySection): Add controlType: "key" for Content#505
Merged
surajshetty3416 merged 1 commit intofrappe:developfrom Mar 3, 2026
Merged
fix(TypographySection): Add controlType: "key" for Content#505surajshetty3416 merged 1 commit intofrappe:developfrom
controlType: "key" for Content#505surajshetty3416 merged 1 commit intofrappe:developfrom
Conversation
by default `controlType` is `style`, this caused dynamic values being assigned as `type: style`. this resulted in a bug where the dynamic value would not actually render as it depends on the `type` to be `key`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #505 +/- ##
========================================
Coverage 63.01% 63.01%
========================================
Files 28 28
Lines 2739 2739
========================================
Hits 1726 1726
Misses 1013 1013 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
surajshetty3416
approved these changes
Mar 3, 2026
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by default
controlTypeisstyle, this caused dynamic values being assigned astype: style. this resulted in a bug where the dynamic value would not actually render as it depends on thetypeto bekey.