Skip to content

fix(PlacementControl): increase button click area to match hovered icon#499

Merged
surajshetty3416 merged 1 commit intofrappe:developfrom
stravo1:fix-placement-control-click-space
Feb 23, 2026
Merged

fix(PlacementControl): increase button click area to match hovered icon#499
surajshetty3416 merged 1 commit intofrappe:developfrom
stravo1:fix-placement-control-click-space

Conversation

@stravo1
Copy link
Copy Markdown
Member

@stravo1 stravo1 commented Feb 22, 2026

previously the click would register only after putting the pointer on a small vertical click area on the icon, even though the hovered icon would show up much before that.

before:

Screen.Recording.2026-02-22.at.10.31.29.PM.mov

after:

Screen.Recording.2026-02-22.at.10.32.29.PM.mov

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.01%. Comparing base (cbcb353) to head (a0d49bd).
⚠️ Report is 117 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #499   +/-   ##
========================================
  Coverage    63.01%   63.01%           
========================================
  Files           28       28           
  Lines         2739     2739           
========================================
  Hits          1726     1726           
  Misses        1013     1013           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 merged commit d347573 into frappe:develop Feb 23, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants