Skip to content

test(builder_page): added test cases for client scripts#498

Merged
surajshetty3416 merged 2 commits intofrappe:developfrom
stravo1:fix-test-cases-client-script
Feb 22, 2026
Merged

test(builder_page): added test cases for client scripts#498
surajshetty3416 merged 2 commits intofrappe:developfrom
stravo1:fix-test-cases-client-script

Conversation

@stravo1
Copy link
Copy Markdown
Member

@stravo1 stravo1 commented Feb 21, 2026

other fixes include:

  • test cases now properly mimic how Builder saved the body or root blocks for pages.
  • get_html_for with type="attribute" did not work.
  • option to get all results matching a query inget_html_for

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.01%. Comparing base (8f9bd63) to head (2ef5cac).
⚠️ Report is 120 commits behind head on develop.

Files with missing lines Patch % Lines
.../builder/doctype/builder_page/test_builder_page.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #498      +/-   ##
===========================================
+ Coverage    60.66%   63.01%   +2.35%     
===========================================
  Files           28       28              
  Lines         2720     2739      +19     
===========================================
+ Hits          1650     1726      +76     
+ Misses        1070     1013      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 merged commit cbcb353 into frappe:develop Feb 22, 2026
6 of 7 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants