Skip to content

fix(dynamicValues): unparsed Jinja string in absence of dynamic values in components#461

Merged
surajshetty3416 merged 6 commits intofrappe:developfrom
stravo1:dynamic-value-component-fix
Jan 13, 2026
Merged

fix(dynamicValues): unparsed Jinja string in absence of dynamic values in components#461
surajshetty3416 merged 6 commits intofrappe:developfrom
stravo1:dynamic-value-component-fix

Conversation

@stravo1
Copy link
Copy Markdown
Member

@stravo1 stravo1 commented Jan 10, 2026

solves #460

the issue occurred because resetting blocks does not remove dynamic values, so when a component is used in a page, all it's dynamic values are replicated into the block from the component. now while rendering the page, a block's dynamic values are calculated by combining the dynamic values of both the block and the reference block from the component from which it is derived and thus it results in replicated dynamic values. and while resolving the dynamic values the fallback value is recalculated twice and the last time it uses the result which was calculated previously.

the issue occured because restting blocks did not remove dynamic values, so when a component was used in a page, all it's dynamic values are replicated into the block from the component. now while rendering the page, a block's dynamic values are calculated by combining the dynamic values of both the block and the reference block from the component from which it is derived and thus it results in replicated dynamic values. and while resolving the dynamic values the fallback value is recalculated twice and the last time it uses the result which was calculated previously.
@stravo1 stravo1 changed the title fix(dynamicValues): unparsed Jinja string in absence of dynamic values in components #460 fix(dynamicValues): unparsed Jinja string in absence of dynamic values in components Jan 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.90%. Comparing base (25b0e48) to head (a3c7320).
⚠️ Report is 37 commits behind head on develop.

Files with missing lines Patch % Lines
...ilder/builder/doctype/builder_page/builder_page.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #461      +/-   ##
===========================================
+ Coverage    49.26%   52.90%   +3.64%     
===========================================
  Files           28       28              
  Lines         2176     2202      +26     
===========================================
+ Hits          1072     1165      +93     
+ Misses        1104     1037      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416
Copy link
Copy Markdown
Member

@stravo1 Let's add a couple of backend tests for this?

@stravo1
Copy link
Copy Markdown
Member Author

stravo1 commented Jan 11, 2026

@stravo1 Let's add a couple of backend tests for this?

sure 👍🏼

@surajshetty3416 surajshetty3416 merged commit d68b8a7 into frappe:develop Jan 13, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants