Skip to content

Fix CommandSender output buffer overflowing#9888

Merged
nielsm5 merged 15 commits intomasterfrom
bug/fix-commandsender-output
Nov 17, 2025
Merged

Fix CommandSender output buffer overflowing#9888
nielsm5 merged 15 commits intomasterfrom
bug/fix-commandsender-output

Conversation

@nielsm5
Copy link
Member

@nielsm5 nielsm5 commented Nov 16, 2025

No description provided.

@nielsm5 nielsm5 changed the title Use a lambda instead of overriding a method Fix CommandSender output buffer overflowing Nov 16, 2025
try {
process = Runtime.getRuntime().exec(command.toArray(new String[0]));
process = new ProcessBuilder(command.toArray(new String[0]))
.redirectOutput(Redirect.to(stdoutFile.toFile()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan je niet direct een redirect naar de outputstream van een MessageBuilder doen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nee, dit ding heeft geen outputstream support, alleen File :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, begrepen!

@nielsm5 nielsm5 requested a review from evandongen November 17, 2025 09:13
@nielsm5 nielsm5 marked this pull request as ready for review November 17, 2025 09:13
@nielsm5 nielsm5 enabled auto-merge (squash) November 17, 2025 11:46
@nielsm5 nielsm5 disabled auto-merge November 17, 2025 11:53
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@nielsm5 nielsm5 merged commit 4238b1b into master Nov 17, 2025
30 of 33 checks passed
@nielsm5 nielsm5 deleted the bug/fix-commandsender-output branch November 17, 2025 13:03
@nielsm5 nielsm5 linked an issue Nov 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CommandSender blocking when script has a lot of output

3 participants