Add validation that table name and all configured fields are valid#9879
Add validation that table name and all configured fields are valid#9879
Conversation
|
| @Override | ||
| public void start() { | ||
| super.start(); | ||
| // Validate this in start not configure, because a broken configuration could otherwise prevent the startup of the entire application. |
There was a problem hiding this comment.
Is dat niet juist de bedoeling van configure()?
There was a problem hiding this comment.
To prevent starting an adapter, yes.
But adding this validation to configure() now means the whole application becomes non-functional if the validation fails, and not just the adapter in which the misconfigured listener is placed.
That is probably a bug but something that should be addressed outside this PR so for now I've put this validation here.
There was a problem hiding this comment.
I think that might be because this is a listener, is that correct?
If so could you add this to ticket #9824 ?
There was a problem hiding this comment.
I think if the configure() of a pipe throws an exception that would also have the same effect, but this is what triggered me to investigate why startup appears to break when a configure() fails.
I'll add this to #9824 .
Changes
Add validation that table name and all configured fields are valid.
Pull Request Checklist
Issues
Backports
Tests