Add saml2 authentication support for HttpSender#8014
Merged
Conversation
….java Co-authored-by: Niels Meijer <nielsmeijer@hotmail.com>
…ttps://github.com/frankframework/frankframework into 3045/uniform-authentication-method-for-httpsender
… 7683/saml2-support
….java Co-authored-by: Niels Meijer <nielsmeijer@hotmail.com>
Base automatically changed from
3045/uniform-authentication-method-for-httpsender
to
master
December 11, 2024 08:40
core/src/main/java/org/frankframework/http/authentication/SamlAssertionOauth.java
Fixed
Show fixed
Hide fixed
core/src/main/java/org/frankframework/http/authentication/SamlAssertionOauth.java
Fixed
Show fixed
Hide fixed
tnleeuw
requested changes
Dec 11, 2024
core/src/main/java/org/frankframework/http/AbstractHttpSession.java
Outdated
Show resolved
Hide resolved
nielsm5
reviewed
Dec 13, 2024
Member
nielsm5
left a comment
There was a problem hiding this comment.
Een paar kleine zeurpuntjes maar een fantastische uitbreiding op het vorige PR!
core/src/main/java/org/frankframework/http/authentication/SamlAssertionOauth.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/frankframework/http/authentication/SamlAssertionOauth.java
Outdated
Show resolved
Hide resolved
| return doc; | ||
| } | ||
|
|
||
| public String documentToString(Document document) throws Exception { |
Member
There was a problem hiding this comment.
Heel misschien zou je XmlUtils.nodeToString(.., ..) kunnen gebruiken. Ik zie alleen dat OMIT_XML_DECLARATION daar standaard op true staat. Mogelijk maakt dat niet uit.
Contributor
Author
There was a problem hiding this comment.
Die twee properties zijn heel erg belangerijk, omdat anders de signature niet meer klopt. Ik had het hier gisteren ook met Tim over en we kwamen tot de conclusie dat er niet echt iets bruikbaars in XmlUtils zat voor mij.
core/src/main/java/org/frankframework/http/authentication/SamlAssertionOauth.java
Outdated
Show resolved
Hide resolved
…AssertionOauth.java Co-authored-by: Niels Meijer <nielsmeijer@hotmail.com>
…k/frankframework into 7683/saml2-support
tnleeuw
reviewed
Dec 13, 2024
core/src/main/java/org/frankframework/http/authentication/SamlAssertionOauth.java
Outdated
Show resolved
Hide resolved
Contributor
|
@thomaspj10 Zou je alsjeblieft ook even maar de Sonar meldingen kunnen kijken? |
tnleeuw
approved these changes
Dec 13, 2024
|
tnleeuw
approved these changes
Dec 16, 2024
nielsm5
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7683