Fix CORS request pattern matching in authenticators#10387
Merged
nielsm5 merged 1 commit intorelease/9.4from Feb 4, 2026
Merged
Fix CORS request pattern matching in authenticators#10387nielsm5 merged 1 commit intorelease/9.4from
nielsm5 merged 1 commit intorelease/9.4from
Conversation
|
tnleeuw
approved these changes
Feb 3, 2026
evandongen
reviewed
Feb 4, 2026
|
|
||
| try { | ||
| httpSecurityConfigurer.csrf(CsrfConfigurer::disable); // Disable CSRF, post requests should be possible. | ||
| httpSecurityConfigurer.cors(CorsConfigurer::disable); // Disable CORS, post requests should be possible. |
Contributor
There was a problem hiding this comment.
het pr heet 'fix cors request pattern matching' -- hier doe je toch wat anders, je zet cors helemaal uit?
Member
Author
There was a problem hiding this comment.
De spring MVC filter ja. Die is voor WebService endpoints niet handig/belangrijk.
We filteren op options requests om te kijken of we iets met authenticatie moeten doen.
Contributor
There was a problem hiding this comment.
Top, had ik dan in de vorige even gemist.
evandongen
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10342