Conversation
# Conflicts: # pom.xml
|
Beetje dubbelop zo, kijk ook even naar #10216. |
|
All tests passed locally |
console/backend/pom.xml
Outdated
| <groupId>org.springdoc</groupId> | ||
| <artifactId>springdoc-openapi-starter-webmvc-api</artifactId> | ||
| <version>2.8.14</version> | ||
| <version>3.0.0</version> |
There was a problem hiding this comment.
sneaky dependency still included spring boot 3.5.7
|
|
||
| converters.add(new InputStreamHttpMessageConverter()); | ||
| converters.add(new FormHttpMessageConverter()); | ||
| public void configureMessageConverters(HttpMessageConverters.ServerBuilder builder) { |
There was a problem hiding this comment.
extendedMessageConverters is deprecated since jackson 3 is now used
…de-to-spring-7 # Conflicts: # pom.xml
tnleeuw
left a comment
There was a problem hiding this comment.
Ik zie dat alles nu werkt, behalve de Ladybug-integration tests in WildFly...
(
java.lang.NoSuchFieldError: Class com.fasterxml.jackson.annotation.JsonFormat$Shape does not have member field 'com.fasterxml.jackson.annotation.JsonFormat$Shape POJO'
at deployment.iaf-test.war//tools.jackson.databind.ser.BasicSerializerFactory.buildMapSerializer(BasicSerializerFactory.java:692)
at deployment.iaf-test.war//tools.jackson.databind.ser.BasicSerializerFactory.buildContainerSerializer(BasicSerializerFactory.java:491)
)
| @Bean | ||
| public RequestMappingHandlerMapping handlerMapping() { | ||
| RequestMappingHandlerMapping handlerMapping = new RequestMappingHandlerMapping(); | ||
| handlerMapping.setUseTrailingSlashMatch(true); // See wearefrank/ladybug #610 | ||
| return handlerMapping; | ||
| return new RequestMappingHandlerMapping(); | ||
| } |
There was a problem hiding this comment.
Moeten we deze bean nog steeds expliciet aanmaken nu we dit property niet meer hoeven te zetten, of heeft Spring een default instance ervoor wanneer we hem niet zelf maken?
There was a problem hiding this comment.
Aangepast, ik denk dat je gelijk hebt. Even kijken wat dit doet.
There was a problem hiding this comment.
Dit maakt het kapot. Ik heb het weer teruggezet
| <scope>import</scope> | ||
| </dependency> | ||
|
|
||
| <!-- Explicitly define Spring dependencies, to avoid version conflicts with Spring Security (https://www.baeldung.com/spring-security-with-maven) --> |
There was a problem hiding this comment.
Waarom zijn deze dependencies omgewisseld in de POM?
Is het niet netter om alle Spring dependencies bij elkaar te hebben staan, zoals het stond?
There was a problem hiding this comment.
Het stond juist niet bij elkaar, zie de -snip- tussen netty (regel 161) en spring-boot (528). Als je hierboven uitvouwt, zie je juist spring-framework en spring-integration.
| </dependency> | ||
|
|
||
| <!-- Because we use Spring-JCL we don't want Commons Logging. --> | ||
| <!-- Spring-jcl has been deprecated, included commons-logging --> |
There was a problem hiding this comment.
| <scope>import</scope> | ||
| </dependency> | ||
|
|
||
| <!-- Explicitly define Spring dependencies, to avoid version conflicts with Spring Security (https://www.baeldung.com/spring-security-with-maven) --> |
There was a problem hiding this comment.
Het stond juist niet bij elkaar, zie de -snip- tussen netty (regel 161) en spring-boot (528). Als je hierboven uitvouwt, zie je juist spring-framework en spring-integration.
| @Bean | ||
| public RequestMappingHandlerMapping handlerMapping() { | ||
| RequestMappingHandlerMapping handlerMapping = new RequestMappingHandlerMapping(); | ||
| handlerMapping.setUseTrailingSlashMatch(true); // See wearefrank/ladybug #610 | ||
| return handlerMapping; | ||
| return new RequestMappingHandlerMapping(); | ||
| } |
There was a problem hiding this comment.
Aangepast, ik denk dat je gelijk hebt. Even kijken wat dit doet.
… into issue/10200-upgrade-to-spring-7
|
Changes
Pull Request Checklist
Title
Issues
Backports
Documentation
Tests
Breaking changes