Merged
Conversation
a095115 to
4edce8b
Compare
4edce8b to
51a3ae2
Compare
|
evandongen
approved these changes
Dec 15, 2025
tnleeuw
approved these changes
Dec 15, 2025
| } else if (obj instanceof String string) { | ||
| return string; | ||
| } else if (obj instanceof Number) { | ||
| } else if (obj instanceof Number || obj instanceof Boolean) { |
Contributor
There was a problem hiding this comment.
Perhaps:
Suggested change
| } else if (obj instanceof Number || obj instanceof Boolean) { | |
| } else if (obj instanceof Number || obj instanceof Boolean || obj instanceof Date || obj instanceof TemporalAccessor) { |
?
(Needs imports added too, probably, so cannot be applied directly)
| if (value instanceof String string) { | ||
| parameter.setValue(string); | ||
| parameter.setPattern(pattern); | ||
| ((AbstractParameter)parameter).setPattern(pattern); |
Contributor
There was a problem hiding this comment.
Zit de method setPattern(...) niet in de interface IParameter?
En moet die niet gewoon daarin worden toegevoegd, ipv deze rare cast hier te doen?
Member
Author
There was a problem hiding this comment.
Ja eigenlijk wel, maar dan zou ik denk ik net iets te veel conflicten krijgen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #10137 I found a few bugs which I fixed in #10143.
These are the fixes based on 9.3 + some extra tests I created in #10137.