Merged
Conversation
evandongen
approved these changes
Dec 4, 2025
Contributor
evandongen
left a comment
There was a problem hiding this comment.
Paar kleine dingen, verder akkoord!
| return answer; | ||
| } | ||
|
|
||
| private Val method(List<Val> inputArgs, ISender sender) { |
Contributor
There was a problem hiding this comment.
Kan je dit een iets meer beschrijvende naam geven?
| } | ||
|
|
||
| private static String getStyleSheet(IScopeProvider scopeProvider, String styleSheetName) throws ConfigurationException { | ||
| // This does not feel like a json util method. Perhaps we should move it? |
Contributor
There was a problem hiding this comment.
Wordt alleen in DataSonnetPipe en DataSonnetErrorMessageFormatter gebruikt: kan misschien beter naar de DataSonnetUtil?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.