Merged
Conversation
evandongen
approved these changes
Nov 26, 2025
| } | ||
| // Some databases (MySQL, MariaDB, Oracle) do not support parameter type matching from the metadata. For these databases, | ||
| // we should return from this function before we reach this statement. | ||
| int sqlTYpe = parameterMetaData.getParameterType(parameterIndex); |
Contributor
There was a problem hiding this comment.
Suggested change
| int sqlTYpe = parameterMetaData.getParameterType(parameterIndex); | |
| int sqlType = parameterMetaData.getParameterType(parameterIndex); |
Contributor
Author
There was a problem hiding this comment.
Dat is geloof ik nog niemand opgevallen... 😆
| if (!parameterTypeMatchRequired) { | ||
| statement.setString(parameterIndex, value); | ||
| if (value != null) { | ||
| statement.setString(parameterIndex, value); |
Contributor
There was a problem hiding this comment.
Dus hij kan hier dus niet tegen een null value .. /sigh
Contributor
Author
There was a problem hiding this comment.
Eigenlijk denk ik dat hij hier wel tegen een null value kan maar ik vond het netter om het ook hier maar gewoon af te dekken.
Make unit test easier to grasp
|
nielsm5
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix an NPE in SQL parameter conversion
Pull Request Checklist
Title
Issues
Backports
Documentation
Tests
Breaking changes