Skip to content

Make sure that ladybug still produces reports when property ibistesttool.custom is set #10319

@mhdirkse

Description

@mhdirkse

Related Problem or Business Case

Since Frank!Framework commit c49f367, merging PR #10285, ladybug-ff-cypress-test fails. This test has jobs that execute a Maven project that uses the FF! as a dependency. It sets property ibistesttool.custom to change the columns of the table of reports in the debug tab. This is not only done in ladybug-ff-cypress-test but also in projects used by real customers. The mentioned commit introduces a new requirement for projects setting property ibistesttool.custom.

In ladybug-ff-test-webapp, the value of property ibistesttool.custom is: TestLadybugReportTableDifferentViewsDifferentColumns. It includes a Spring configuration file named springIbisTestToolTestLadybugReportTableDifferentViewsDifferentColumns.xml with bean definitions needed to change the table. I could fix this test application by adding file springIbisDebuggerAdviceTestLadybugReportTableDifferentViewsDifferentColumns.xml with the following contents:

<?xml version="1.0" encoding="UTF-8"?>
<beans
    xmlns="http://www.springframework.org/schema/beans"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd"
    >
    <import resource="springIbisDebuggerAdvice.xml"/>
</beans>

When integration specialists do not add this file, Ladybug silently losses the ability to generate reports.

Describe the Feature

I am not sure what feature is needed, but something has to be done. I see the following options:

  • Let starting the Frank!Framework fail when the mentioned extra Spring configuration is missing. This forces integration specialists to add the file before their project goes to production.
  • Let the Frank!Framework accept projects that set ibistesttool.custom but do not provide a related springIbisDebuggerAdvice.

Collaboration with External Companies

No, community resolution only

Anything else?

No response

Metadata

Metadata

Assignees

Labels

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions