Conversation
|
There is a slightly related issue, that is beyond scope of this PR. Currently in ssr mode server always returns 200 status even for not found pages, but it might be nice to return a 404 status code for those pages for semantics. const route = router.currentRoute.value
const statusCode = route.fullPath === '/' || route.matched.length > 0 ? 200 : 404 |
|
@m3hari Thanks! I think, however, this would break some use cases like throwing errors or returning statuses from the props handler: #60 What we want to do is remove the default-to-404 only when there is no props handler during rendering, which is happening here. We could start returning That should make it work for your use-case and also keep it working when a proper status code is returned from the props handler. |
|
@frandiox Updated accordingly thanks for the guidance. |
|
@m3hari I've made a small fix and I think we can release it now. Thanks! |
As stated in the title closes #66