changed peerDependencies to support react 17#847
changed peerDependencies to support react 17#847mattgperry merged 1 commit intomotiondivision:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 00ce7f5:
|
|
Excellent thanks for this |
| "yarn-deduplicate": "^1.1.1" | ||
| }, | ||
| "dependencies": { | ||
| "@emotion/is-prop-valid": "^0.8.2", |
There was a problem hiding this comment.
@Gerigot
Could you please clarify whether duplicating this from optionalDependencies was necessary?
There was a problem hiding this comment.
this is probably a mistake and should be removed
There was a problem hiding this comment.
Oh I see now.
I'm sorry, yes it was a mistake, probably done automatically by my IDE, if it's a problem I'll remove it.
There was a problem hiding this comment.
I'm using preact in projects w/ framer-motion and was just passing by :)
Since you probably have a working state w/ React 17, could you please test whether it still installs w/o this dep in dependencies and remove afterwards?
There was a problem hiding this comment.
I'm an idiot.
I was "fixing" (removing) the dependency and I screw the things up with git. so I've created a new pull request with the fix.
There was a problem hiding this comment.
I'm confused. I have a Next.js project that uses React 17. When I do npm i framer-motion I still get the peer dependency error. I thought the problem was fixed? Is there something I need to do to get the latest, fixed version of your library to install? I forced the install with npm i framer-motion --force but was hoping this wouldn't be necessary...thanks!
There was a problem hiding this comment.
I have the same exact problem as Amasa-Delano .
There was a problem hiding this comment.
I see that this pull request has been merged in the main branch 11 days ago, but no version of the library has been created since then.
The problem should be that the last version on NPM doesn't have this fix.
You'll have to wait till a version will be created or for now download and build it by yourself.
I'm not the owner of the project, so I don't know if is planned to create a new version and when will that happen.
As a complementary info, if you check the issue #846 is still open and that, I believe, is because there is still no release with this fix, put your comments in the issue, probably is more visible.
There was a problem hiding this comment.
thanks for your quick response and help.
As stated in the issue #846 it was impossible to use this library with react 17.
I've modified the peerDependencies to make it work