Generalise types of run*Server which never cleanly return#13
Merged
snoyberg merged 1 commit intofpco:masterfrom Dec 17, 2014
DaveCTurner:generalise-types
Merged
Generalise types of run*Server which never cleanly return#13snoyberg merged 1 commit intofpco:masterfrom DaveCTurner:generalise-types
snoyberg merged 1 commit intofpco:masterfrom
DaveCTurner:generalise-types
Conversation
Member
|
I need to think about this a bit more. I thought about this change at some point, and I think I came up with a concrete example of breakage from making the change, but I'm not certain. |
Member
|
I've emailed the cafe about this, let's see if anyone has insight. |
Member
|
After the cafe discussion, I've decided to go ahead with this change as a minor version bump (0.1.8). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat more controversial: These functions never cleanly return so
IO ()can beIO a.On first reading, I figured they forked a thread that ran the
acceptloop based on theIO ()return type.Not clear to me whether this is a breaking API change or whether it's strictly more general. Feel free to reject!
Cheers,