Skip to content

Add wpsModifyResponseHeaders function#48

Merged
snoyberg merged 2 commits intofpco:masterfrom
adinapoli:adinapoli/wpsModifyResponseHeaders
Jun 25, 2024
Merged

Add wpsModifyResponseHeaders function#48
snoyberg merged 2 commits intofpco:masterfrom
adinapoli:adinapoli/wpsModifyResponseHeaders

Conversation

@adinapoli
Copy link
Copy Markdown
Contributor

Hey @snoyberg ,

I hope you are safe and healthy.

This commit adds a new function to the WaiProxySettings called wpsModifyResponseHeaders, that allows modifying the response headers before they are sent upstream. The primary usage would be for example to tweak things like the Content-Security-Policy that now modern browsers are enforcing when it comes to static content, and that needs to be amended in case the proxied server is too stringent.

If you are not fan of the approach let me know, I'm happy to make changes as needed.

Take care,

Alfredo

This commit adds a new function to the `WaiProxySettings` that allows
modifying the response headers before they are sent upstream.
Copy link
Copy Markdown
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection from me. To be honest though, this library isn't in active maintenance right now. If you're still using it, interested in becoming a comaintainer?

@adinapoli
Copy link
Copy Markdown
Contributor Author

No objection from me. To be honest though, this library isn't in active maintenance right now. If you're still using it, interested in becoming a comaintainer?

Unfortunately I'm father of two small twins, so time is really tight for me as well 😉 I'm happy to occasionally help, but I'm afraid that as far as comaintenance goes, I have to decline, sorry 😢

@snoyberg
Copy link
Copy Markdown
Member

Congratulations on the twins!

@adinapoli
Copy link
Copy Markdown
Contributor Author

Congratulations on the twins!

Thanks! They are 2.5 years old now, but they are demanding to say the least 😅 I haven't forgot making amendments on this PR, but I'm out of hours for this particular client, so I will deal with those next week :) Take care!

@snoyberg
Copy link
Copy Markdown
Member

Wow small world, my twins are also 2.5 years old!

@adinapoli adinapoli requested a review from snoyberg June 24, 2024 05:31
@snoyberg snoyberg merged commit 08d3b8e into fpco:master Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants