Skip to content

Remove Custom Setup.hs#27

Merged
andreasabel merged 5 commits intofpco:masterfrom
mpickering:wip/remove-setup
Nov 13, 2024
Merged

Remove Custom Setup.hs#27
andreasabel merged 5 commits intofpco:masterfrom
mpickering:wip/remove-setup

Conversation

@mpickering
Copy link
Copy Markdown
Contributor

@mpickering mpickering commented Sep 27, 2023

Cabal since version 1.20.0.0 has defined the HADDOCK_VERSION macro which indicates when we are building haddock documentation.

This alleviates the need for a custom Setup.hs script.

@mpickering
Remove Custom Setup.hs
2eb2671 
Cabal since version 1.20.0.0 has defined the __HADDOCK_VERSION__ macro
which indicates when we are building haddock documentation.

This alleviates the need for a custom Setup.hs script.
@andreasabel andreasabel mentioned this pull request Oct 11, 2023
Open
@andreasabel
Copy link
Copy Markdown
Collaborator

andreasabel commented Nov 12, 2024

@snoyberg : Would you be willing to move maintainership to me?

  • Write access to this repo.
  • Uploader rights on hackage.

@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Nov 13, 2024

Sounds great, what's your Hackage username?

@andreasabel
Copy link
Copy Markdown
Collaborator

andreasabel commented Nov 13, 2024

I am AndreasAbel https://hackage.haskell.org/user/AndreasAbel

@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Nov 13, 2024

Added on Hackage and invite sent here on GitHub. Welcome aboard!

@andreasabel
Copy link
Copy Markdown
Collaborator

andreasabel commented Nov 13, 2024

Excellent!
My goal is to release this PR as 0.4.14.1.

@andreasabel
Whitespace fixes: tabs to spaces
74084cf
@andreasabel
system-fileio: fix testsuite build with unix-2.8
8f18c71
@andreasabel
system-filepath: comment out broken test validity.posix
04f6ce9 
The generator for file paths seems to be broken (maybe because of
Unicode); it generates file paths with \NUL characters.
@andreasabel andreasabel self-assigned this Nov 13, 2024
@andreasabel andreasabel added this to the system-filepath 0.4.14.1 milestone Nov 13, 2024
@andreasabel
Copy link
Copy Markdown
Collaborator

andreasabel commented Nov 13, 2024

Candidates:

@andreasabel
system-filepath 0.4.14.1 and system-fileio 0.3.16.5
f9f3295 
- Haskell-CI for GHC 8.0 - 9.12.0
- Test building with Stack (9.4, 9.6, 9.8)
- Cosmetic fixes in .cabal files
- Remove broken links to plus.google.com from README and .cabal files
- changelog
@andreasabel andreasabel merged commit f9f3295 into fpco:master Nov 13, 2024
@andreasabel
Copy link
Copy Markdown
Collaborator

andreasabel commented Nov 13, 2024 •
edited
Loading

Published.

In the end, this took me a full day since other packages from the Millikin-universe had fallen behind: options, chell, chell-hunit, chell-quickcheck. Further outdated dependencies were: monads-tf, patience.

2024-11-13T16:42:29Z AndreasAbel chell-0.5.0.2-r2
2024-11-13T15:22:52Z AndreasAbel chell-quickcheck-0.2.5.4-r1
2024-11-13T15:22:32Z AndreasAbel chell-hunit-0.3.0.2-r1
2024-11-13T15:08:56Z AndreasAbel options-1.2.1.2-r2
2024-11-13T14:57:06Z AndreasAbel monads-tf-0.3.0.1-r2
2024-11-13T10:45:17Z AndreasAbel patience-0.3-r1

@andreasabel andreasabel mentioned this pull request Nov 13, 2024
Merged
@alexfmpe alexfmpe mentioned this pull request Feb 1, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@andreasabel andreasabel

Labels

None yet

Projects

None yet

Milestone

system-filepath 0.4.14.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mpickering @andreasabel @snoyberg