I have tries with an empty Firefox this in console, and it seems that a URL with the socks protocol is not parsed correctly.

That is why FoxyProxy code reprocesses it. I don't get any error when I try it.

The code checks if protocol is http: or https:
if not:
- Sets the type according to the protocol
- Changes the protocol to http:
- Runs new URL(url) again with http:

browser-extension/src/content/options.js

Lines 1019 to 1041 in 172c936

    
           // convert old schemes to type 
        
           let url; 
        
           try { url = new URL(item); } 
        
           catch (error) { 
        
             alert(`${error}\n\n${item}`); 
        
             return; 
        
           } 
        
           // convert old schemes to type 
        
           let type = url.protocol.slice(0, -1); 
        
           if (!['http', 'https'].includes(type)) { 
        
             const scheme = { 
        
               proxy: 'http', 
        
               ssl: 'https', 
        
               socks4: 'socks4', 
        
               socks5: 'socks5', 
        
               socks: 'socks5', 
        
             }; 
        
             scheme[type] && (type = scheme[type]); 
        
             url.protocol = 'http:'; 
        
             url = new URL(url); 
        
           }

	// convert old schemes to type
	let url;
	try { url = new URL(item); }
	catch (error) {
	alert(`${error}\n\n${item}`);
	return;
	}

	// convert old schemes to type
	let type = url.protocol.slice(0, -1);
	if (!['http', 'https'].includes(type)) {
	const scheme = {
	proxy: 'http',
	ssl: 'https',
	socks4: 'socks4',
	socks5: 'socks5',
	socks: 'socks5',
	};

	scheme[type] && (type = scheme[type]);
	url.protocol = 'http:';
	url = new URL(url);
	}

Incorrect import of a proxy with socks protocol #120

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Incorrect import of a proxy with `socks` protocol #120