Skip to content

Godot 4.2 and up breaks commands #141

@elementbound

Description

@elementbound

EditorPlugin.get_editor_interface() was deprecated in Godot 4.2, which breaks Vest's internal mechanism for passing around the EditorInterface instance. This results in "Internal script error! Opcode: 61" errors.

In addition, VestLocalSettings can't find the appropriate config file. Instead of running it in _static_init(), it should be triggered by the addon load, even though that doesn't fix the issue of random nulls ( the candidate array somehow becomes null, the path candidate somehow becomes null in the loop, etc. )

Errors produced in a fresh install on Godot 4.2.2 plugin enable:

  Unable to convert array index 0 from 'Nil' to 'String'.
  res://addons/vest/vest-local-settings.gd:10 - Invalid type in static function 'file_exists' in type 'FileAccess'. Cannot convert argument 1 from Nil to String.
  res://addons/vest/ui/vest-ui.gd:99 - Invalid set index 'text' (on base: 'LineEdit') with value of type 'Nil'.
  modules/gdscript/gdscript_vm.cpp:2530 - Condition ' !nc ' is true. Breaking..:
  res://addons/vest/vest-singleton.gd:178 - Internal script error! Opcode: 61 (please report).
  res://addons/vest/commands/go-to-test-command.gd:90 - Cannot call method 'get_command_palette' on a null value.
  modules/gdscript/gdscript_vm.cpp:2530 - Condition ' !nc ' is true. Breaking..:
  res://addons/vest/vest-singleton.gd:178 - Internal script error! Opcode: 61 (please report).
  res://addons/vest/commands/create-test-command.gd:64 - Cannot call method 'get_command_palette' on a null value.
  modules/gdscript/gdscript_vm.cpp:2530 - Condition ' !nc ' is true. Breaking..:
  res://addons/vest/vest-singleton.gd:178 - Internal script error! Opcode: 61 (please report).
  res://addons/vest/commands/run-test-command.gd:51 - Cannot call method 'get_command_palette' on a null value.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions