Skip to content

fix: RewindableAction to handle later ticks#534

Merged
elementbound merged 3 commits intomainfrom
fix/tickset-beyond-latest-serialize
Nov 21, 2025
Merged

fix: RewindableAction to handle later ticks#534
elementbound merged 3 commits intomainfrom
fix/tickset-beyond-latest-serialize

Conversation

@elementbound
Copy link
Copy Markdown
Contributor

When modifying a rewindable action from outside of its parent, it may set a tick in one loop, but not in the next one. For example, the player hits a spike, and the spike sets the RewindableAction for tick 15. On the next loop, the player doesn't hit the spike on tick 15, but is also not simulated for tick 15 since it doesn't have input.

This results in TicksetSerializer's assert failing, because there's an active tick past the last set one.

Instead, RewindableAction now serializes the last set tick, even if it was not set in the current loop. TicksetSerializer will not serialize ticks outside of the specified range.

Fixes #532

@elementbound elementbound merged commit c7fc6ea into main Nov 21, 2025
2 checks passed
@elementbound elementbound deleted the fix/tickset-beyond-latest-serialize branch November 21, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RewindableAction - Trying to serialize ticks beyond latest !

1 participant