feat: RewindableState signals#494
Merged
elementbound merged 10 commits intofoxssake:mainfrom Sep 27, 2025
Merged
Conversation
RickyYCheng
commented
Sep 27, 2025
RickyYCheng
commented
Sep 27, 2025
Contributor
|
Thanks and congrats on the contrib @RickyYCheng 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think adding three signals,
state_enter,state_tick, andstate_exit, for the leaf states of the state machine would be a great choice.This has several benefits:
Through Discord discussions, add the
RewindableState._prevent_transitionfield andRewindableState.prevent_transition()toRewindableStateto deny state entry.It's not entirely clear how to change
can_enterto achieve this. However, this can be done by executingprevent_transitionfornext_stateinstate_exit. The same applies to overridingexit.This might change our expectations for
can_enter. If overriding users also useprevent_transition, they don’t actually need to overridecan_enter.Besides, I suppose there is no need for sync-ing
_prevent_transitionfield since will reset it to false each transition.And this field is not accessible in
tick.Finally, this change is fully C# compatible.