fix: Avoid NaNs at very low latencies#469
Merged
elementbound merged 2 commits intomainfrom Jun 13, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkTimeSynchronizersamples the host's clock and takes a weighted average of the clock offsets, based on the roundtrip time. If the roundtrip time is very close to zero, the weight itself will zero, thus resulting in a division by zero. This value is then used to adjust the clock, setting it to NaN. This blocks the network tick loop.To fix this, a check is added that will avoid the weighted average if the RTT is too low, and calculates a regular average instead.
Try the addon: netfox.v1.26.2.zip