doc: Use physics_factor in all example snippets#461
Merged
elementbound merged 1 commit intofoxssake:mainfrom Jun 8, 2025
Merged
doc: Use physics_factor in all example snippets#461elementbound merged 1 commit intofoxssake:mainfrom
elementbound merged 1 commit intofoxssake:mainfrom
Conversation
…calling move_and_slide.
Contributor
|
Thanks for the PR, looks good at first glance! Will return to it a bit later for a proper check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying out Netfox and was confused why my velocity was suddenly infinite. I eventually double checked the caveats page and saw that I'd miss the
/=line after my call tomove_and_slide().Changing all of the docs to consistently do the divide after calling
move_and_slide()will help others avoid stubbing their toes on this as they try out Netfox.I guess this results in 3 extra float divides per
_rollback_tickcall if your game *does *resetvelocityfor each tick, but that seems like a less common usage since move_and_slide altersvelocityon collision to implement the "slide" behavior.