chore: Cache project settings#442
Merged
elementbound merged 3 commits intofoxssake:mainfrom Apr 8, 2025
Merged
Conversation
Mickeon
reviewed
Oct 23, 2025
|
|
||
| # Get the gravity from the project settings to be synced with RigidBody nodes. | ||
| var gravity = ProjectSettings.get_setting("physics/3d/default_gravity") | ||
| var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity") |
There was a problem hiding this comment.
I just wanted to point out, as I did in the Netfox chat, that all of these &"" literals are useless, because all methods related to project settings accept String, not StringName. You must've been confusing them for Object.get.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304