fix: _HistoryBuffer snapshot return #418
Merged
elementbound merged 3 commits intofoxssake:mainfrom Feb 23, 2025
Merged
Conversation
Fixed return data to be in line with generic _HistoryBuffer implementation, added specific return data to _PropertyHistoryBuffer.
Contributor
|
Nice catch, I remember messing around this part but forgot to change it 😄 Could you please do a version bump and add a test case for this? |
- Updating semantic versioning. - Added Vest test.
- Updated versioning for all relevant plugins.
elementbound
approved these changes
Feb 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_HistoryBuffer.get_snapshot()was returning_PropertySnapshot.new()if unable to find the relevant tick. While this is useful for the specific_PropertyHistoryBufferimplementation, it shouldn't be the default for the generic implementation._HistoryBufferimplementation, added specific return data to_PropertyHistoryBuffer.