chore: Remove MultiplayerSpawner from examples#370
Merged
elementbound merged 2 commits intofoxssake:mainfrom Jan 5, 2025
Merged
chore: Remove MultiplayerSpawner from examples#370elementbound merged 2 commits intofoxssake:mainfrom
elementbound merged 2 commits intofoxssake:mainfrom
Conversation
As far as I can tell, these are unused. I'm guessing they probably can't be used safely with netfox as they aren't rollback-aware. Remove these to avoid confusion about how players are spawned.
Contributor
|
Good catch, MultiplayerSynchronizer indeed became unnecessary! I wouldn't completely rule out using them though, they can be fine for non-rollback nodes, or nodes that spawn at the start of the game and are present until it ends. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, these are unused.
I'm guessing they probably can't be used safely with netfox as they aren't rollback-aware. Remove these to avoid confusion about how players are spawned.