refactor: NetfoxLogger no longer depends on netfox#336
Merged
elementbound merged 3 commits intomainfrom Nov 21, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly referencing
NetworkTimeandNetworkEventsin_NetfoxLoggermeans thatnetfox.internalsdepends onnetfox. This creates both a circular dependency, and an unnecessary dependency fornetfox.noray. The noray integration doesn't need netfox itself to work properly, and should be kept usable without netfox itself.Instead, tags can be registered in
_NetfoxLogger, which are functions that provide information for all log messages. Tags are ordered, to ensure the same log message format, regardless of the order the registering may run their init functions.