feat: Add display state change signal to RewindableStateMachine#331
feat: Add display state change signal to RewindableStateMachine#331elementbound merged 11 commits intofoxssake:mainfrom
Conversation
explorer_pSTlOHwPzp-00.00.06.357-00.00.26.416.mp4Let me know if this solves the base issue and I'll address the other issues mentioned here and by BatteryAcidDev on discord. |
08ebb39 to
d37b47d
Compare
d5f2844 to
5caa45e
Compare
| for child in find_children("*", "RewindableState", false): | ||
| _available_states[child.name] = child | ||
| func _notification(what: int): | ||
| if what == NOTIFICATION_READY: |
There was a problem hiding this comment.
This does the same as the _ready callback, why the change?
There was a problem hiding this comment.
it's so users can comfortably add their own logic without overriding what's underneath (which is what batteryaciddev bumped into). I know you can call _ready.super() but this is just an easier solution.
There was a problem hiding this comment.
Gotcha! I've restored this form. Though long-term I'm unsure of this pattern - while this is comfortable for the user, it's less explicit and more magic.
Anyway, let's leave this in and see the reactions.
|
Confirmed this is working just fine, even at high latency. |
Attempting to fix #327
While this resolves the issue of synchronizing states across all clients and host, we're 2 steps back with the state flickering after certain events such as landing a jump.