Variable rename: pe to property_entry#305
Merged
elementbound merged 9 commits intofoxssake:refactor/rename-varsfrom Nov 3, 2024
Merged
Variable rename: pe to property_entry#305elementbound merged 9 commits intofoxssake:refactor/rename-varsfrom
pe to property_entry#305elementbound merged 9 commits intofoxssake:refactor/rename-varsfrom
Conversation
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
Merged
Contributor
Sure, but that's not the convention in this repo. Please keep on respecting the convention. Thanks!
You can do an interactive rebase which lets you clean up the commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatively, could stay as
peand simply have the static typing declaration like this:I prefer the static typing declaration myself, e.g. because it gives you the type and highlights it so you can just press
Ctrlon itBtw that commit chain is weird, should I try to rebase or squash or sth? Has been a while since I did that