Implement player id and session id#269
Closed
TheYellowArchitect wants to merge 12 commits intofoxssake:mainfrom
Closed
Implement player id and session id#269TheYellowArchitect wants to merge 12 commits intofoxssake:mainfrom
TheYellowArchitect wants to merge 12 commits intofoxssake:mainfrom
Conversation
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
This was referenced Sep 2, 2024
Contributor
|
Thank you for the contrib but I would not like to add this feature at this point - more details in #256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation of #256 which also solves #242 and #238
player_idis used here for projectile IDs. Though I place this in draft becausefire()should becomefire(avatar_player_id)so as to generate the unique id via the new method. But there is a conflict. Thefire()input must be invoked by other players via input (so it should be THEIR player id, not local player id) and currently it fires only locally (the bomb projectile is synced via state, not by invoking the inputfire()).In simpler words, it stays as draft because a slight input refactor to have fire input passed into
_inputs#253 is more important than this PR.Anyway, as for
player_joined_at_tick, it's not included here as it would make this class bloated and would have to introduce race conditions.