Skip to content

fix: hdpi svg icons#213

Merged
elementbound merged 4 commits intofoxssake:mainfrom
bryanmylee:hdp-icons
Mar 8, 2024
Merged

fix: hdpi svg icons#213
elementbound merged 4 commits intofoxssake:mainfrom
bryanmylee:hdp-icons

Conversation

@bryanmylee
Copy link
Copy Markdown
Contributor

Godot has a bug where small SVG icons aren't scaled up when the editor is.

This results in a minor icon issue on the scene tree.

bugged hdpi

Of course, the best fix is an upstream fix to the editor itself, but pending that, scaling up the icons seems to do the trick.

This works on both 100% and 200% scaling.

fixed regular dpi fixed hdpi

@elementbound
Copy link
Copy Markdown
Contributor

Thank you for the PR @bryanmylee!
Would you be willing to do the following?

  • Resize the SVGs to 64x64 instead? That way we can support 4x resolution ( editor settings only go up to 3x ), while keeping VRAM usage much lower.
  • Do a patch version bump - if you're on Linux/Mac, you can just run sh/version bump patch and it will automatically update all addon versions.

I can also take care of it if you give me write permissions. Thanks!

@bryanmylee
Copy link
Copy Markdown
Contributor Author

The sh/version script doesn't work for me unfortunately, seems like sh/shared.sh throws an error:

sh/shared.sh: line 6: netfox.noray: syntax error: invalid arithmetic operator (error token is ".noray")
sed: 1: "addons/netfox/plugin.cfg": command a expects \ followed by text
sed: 1: "addons/netfox.internals ...": command a expects \ followed by text
sed: 1: "addons/netfox.noray/plu ...": command a expects \ followed by text
sed: 1: "addons/netfox.extras/pl ...": command a expects \ followed by text
1.4.1

@bryanmylee
Copy link
Copy Markdown
Contributor Author

I've manually bumped the version!

@elementbound
Copy link
Copy Markdown
Contributor

Thanks @bryanmylee, much appreciated!

@elementbound elementbound merged commit 296bd3d into foxssake:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants