Skip to content

Redirect dead link (error 404) to proper documentation link#183

Merged
elementbound merged 1 commit intofoxssake:mainfrom
TheYellowArchitect:patch-3
Jan 15, 2024
Merged

Redirect dead link (error 404) to proper documentation link#183
elementbound merged 1 commit intofoxssake:mainfrom
TheYellowArchitect:patch-3

Conversation

@TheYellowArchitect
Copy link
Copy Markdown
Contributor

@TheYellowArchitect TheYellowArchitect commented Jan 15, 2024

https://foxssake.github.io/netfox/tutorials/ticking-in-sync/

Btw on the line above this pull request's change, I do not know where it directs. I would love to read the latest part.

@@ -2,7 +2,7 @@ extends Node
## This class handles timing.
##
## @tutorial(Ticking in sync): https://foxssake.github.io/netfox/tutorials/ticking-in-sync/
Copy link
Copy Markdown
Contributor

@elementbound elementbound Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a leftover link. When I started writing docs originally, this was planned to be a tutorial on the how and why of time syncing. However, I deemed the original version of most of the docs too verbose and dwelling too much on history. Granted, the history of how things evolved is always interesting, but a networking addon's tutorial page is not the best place for it imo :)

If you're interested, here's the original version of the doc from an earlier commit:
b5ccce7

Created #186 for this.

Copy link
Copy Markdown
Contributor Author

@TheYellowArchitect TheYellowArchitect Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation, and especially the link. I am happy to see all of it is intact, though I would argue the old version's "Time"

"Regular" time combines the best of both worlds - it is based on an estimate of
the host's time, but doesn't jump around. It is synced to the host once, and
then only ever updated in case the clocks go extremely out of sync for whatever
reason.

Use this as your go-to solution, and specifically when you need to share
timestamps between clients - for example sending a message saying Player C
fired their gun at tick 357

is crystal clear compared to current one. As for the rest, I would argue current network-time is better than that old documentation page

@elementbound elementbound merged commit 0461310 into foxssake:main Jan 15, 2024
@elementbound
Copy link
Copy Markdown
Contributor

Thank you for the fix @TheYellowArchitect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants