Skip to content

RollbackSynchronizer ack's to itself on mixed authorityΒ #373

@elementbound

Description

@elementbound

πŸ› Description

RollbackSynchronizer can end up sending full state ack's to the local peer. Example node tree:

Player (1)
β”œβ”€β”€ Input (2)
β”œβ”€β”€ Preview (2)
└── RollbackSynchronizer (1)

The parentheses mark ownership. In this case, on peer 1, RollbackSynchronizer will receive Preview's full state from peer 2. Then, the ack will be sent to the RollbackSynchronizer's owner, 1.

This results in an error, as the "call_remote" RPC will be called on the local peer.

To fix, the ack should be sent to the sender ( who sent the state itself ), instead of the RollbackSynchronizer's owner.

Versions

  • Godot version: v4.3.stable.custom_build [f491b2a5d]
  • netfox version: 1.14.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions