Skip to content

Limit number of rollback ticks #323

@elementbound

Description

@elementbound

🐛 Description

NetworkRollback doesn't check or limit the number of rollback ticks about to be ran. Malicious or erroneous messages can cause the host to run an unreasonable amount of rollback ticks.

Found during #176 / #314

Use case

This affects all games using netfox with rollback.

Implementation notes

NetworkRollback should either honor the history_limit setting when running the rollback tick loop, or get a new project setting to limit the maximum number of rollbacks.

RollbackSynchronizer should reject inputs that are too old.

Distribution

netfox core

Notes

This is a fix and not a feature, even though the feature template was easier to fill as I'm describing something to implement 🙂

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions