-
-
Notifications
You must be signed in to change notification settings - Fork 60
Expand History Limit #248
Copy link
Copy link
Closed
Description
Currently, the variable history_limit covers BOTH state and inputs. They should be seperated. One variable for limit to states, a seperate one for limit to inputs.
Also, a value of -1, should make them unable to be erased. Yes, it will be costly, but for inputs it shouldnt be a problem and helps with debugging (and saving replays in the future)
Lastly, no idea what the below variable _data is for (in the class RollbackFreshnessStore), is it inputs or states?
Even type hint wouldn't help here because both states and inputs are dictionaries lol
func trim():
while _data.size() > NetworkRollback.history_limit:
_data.erase(_data.keys().min())Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels