WIP: Add option for trailing haddocks in records#98
Closed
expipiplus1 wants to merge 2 commits intofourmolu:mainfrom
Closed
WIP: Add option for trailing haddocks in records#98expipiplus1 wants to merge 2 commits intofourmolu:mainfrom
expipiplus1 wants to merge 2 commits intofourmolu:mainfrom
Conversation
TODO: Tests TODO: Disallow this in combination with trailing comma style
Contributor
Author
|
If I were to fix the merge conflicts would it stand a chance of getting merged? |
Collaborator
|
Thanks! I've wanted this a while. I have some suggestions and the easiest thing was to make a separate branch. I hope you don't mind. See #124. |
c7364ed to
40bcc74
Compare
Collaborator
|
@expipiplus1 can we close this? |
Contributor
Author
|
@brandonchinn178 yes! thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Tests
TODO: Disallow this in combination with trailing comma style