Skip to content

Fix multiline haddocks in indented contexts#64

Merged
georgefst merged 6 commits intomasterfrom
unknown repository
Mar 4, 2021
Merged

Fix multiline haddocks in indented contexts#64
georgefst merged 6 commits intomasterfrom
unknown repository

Conversation

@brandon-leapyear
Copy link
Copy Markdown
Contributor

@brandon-leapyear brandon-leapyear commented Mar 4, 2021 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

Fixes #63
Fixes #53

@brandon-leapyear brandon-leapyear mentioned this pull request Mar 4, 2021
Closed
georgefst
georgefst requested changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@georgefst georgefst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks!

Just the minor quibble on whitespace.

@georgefst georgefst merged commit 727e095 into fourmolu:master Mar 4, 2021
@brandon-leapyear
Copy link
Copy Markdown
Contributor Author

brandon-leapyear commented Mar 13, 2021 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

@georgefst is this fix worth a patch release to hackage?

@georgefst
Copy link
Copy Markdown
Collaborator

georgefst commented Mar 13, 2021

We should hopefully be able to batch this up with a few other upcoming changes. Unless you could really do with it on Hackage for any reason?

@brandon-leapyear
Copy link
Copy Markdown
Contributor Author

brandon-leapyear commented Mar 13, 2021 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

If there are upcoming changes, then it can wait. As long as there's some release within a few weeks?

@gustavoavena
Copy link
Copy Markdown
Contributor

gustavoavena commented May 13, 2021 •
edited
Loading

Is there an ETA for when this fix will be released?
Thanks!

Edit
I may have found a bug and before creating an issue, I looked for existing ones to see if it was already brought up. I initially thought that it was related to this fix, but I just tested it with these changes and the issue is still there. I'll probably open a new issue with more details later today 🙂

@brandon-leapyear brandon-leapyear deleted the chinn/multiline-haddocks branch May 20, 2021 19:12
@brandon-leapyear
Copy link
Copy Markdown
Contributor Author

brandon-leapyear commented Jun 2, 2021 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

@georgefst any updates on a Hackage release?

@georgefst georgefst mentioned this pull request Aug 8, 2021
Closed
@brandon-leapyear brandon-leapyear mentioned this pull request Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgefst georgefst Awaiting requested review from georgefst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Formatting changes AST in indented haddocks Formatting changes AST in header haddock

3 participants

@brandon-leapyear @georgefst @gustavoavena