Conversation
Previous behaviour caused AST changes on formatting in cases like `infix/do.hs`.
Closed
Collaborator
Author
|
As a more general point, I think we probably want to keep code changes small for the foreseeable future, in order to continue to merge in improvements from And it would be great if, once we have some configurability, we could fully simulate the behaviour of |
This was referenced Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The more I've thought about this, it seems that the behaviour causing the remaining test failure at #1 is really very specific to that sort of expression (a
doblock in the LHS of an infix operator). And frankly I'd be suspicious of code that looked like that anyway - before today I wouldn't have been confident at a glance of how that parses.So I figure it's better to treat it as the unusual edge case it is. #5 seems overkill, since, as one fix led to another, the changes became more pervasive than we'd want, in terms of behaviour and LOC. This patch gets straight to the point, and is thus much smaller in both senses.