Skip to content

let-style improvements#257

Merged
brandonchinn178 merged 3 commits intomainfrom
let-style
Dec 3, 2022
Merged

let-style improvements#257
brandonchinn178 merged 3 commits intomainfrom
let-style

Conversation

@brandonchinn178
Copy link
Copy Markdown
Collaborator

Fix #256

@github-actions
Copy link
Copy Markdown

👋 @brandonchinn178
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines in DEVELOPER.md. We will review it as soon as possible!

Reviewer: Please verify the following things have been done, if applicable.

  • A file has been added to changelog.d/
  • "Configuration > Available options" section in README.md has been updated
  • "Configuration > Specifying configuration" section in README.md has been updated
  • fourmolu.yaml updated to stay in sync with config in README.md
  • Tests have been added

@georgefst
Copy link
Copy Markdown
Collaborator

georgefst commented Dec 2, 2022

Just to be absolutely clear, from #256 (comment):

So the first one is definitely unintentional, I'll make that fix.

This is precisely what the second commit achieves.

The second one is what I would expect from auto, but I didn't realize it would break existing formatted code. So I'll just change the default to be inline

And this is the third EDIT: commit no longer exists because we opted to keep the current behaviour - see #256 (comment).

Correct?

@brandonchinn178
Copy link
Copy Markdown
Collaborator Author

@georgefst correct

@brandonchinn178 brandonchinn178 marked this pull request as ready for review December 3, 2022 00:42
@brandonchinn178 brandonchinn178 merged commit 71f2b33 into main Dec 3, 2022
@brandonchinn178 brandonchinn178 deleted the let-style branch December 3, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

let-style: auto leads to reformatting

2 participants