Merged
Conversation
brandonchinn178
commented
Sep 30, 2021
Comment on lines
+404
to
410
| inciBy step (R m) = R (local modRC m) | ||
| where | ||
| modRC rc = | ||
| rc | ||
| { rcIndent = roundDownToNearest step (rcIndent rc) + step | ||
| } | ||
| roundDownToNearest r n = (n `div` r) * r |
Collaborator
Author
There was a problem hiding this comment.
now this matches Ormolu's version (modulo roundDownToNearest)
brandonchinn178
commented
Sep 30, 2021
Comment on lines
+607
to
+609
| | isOneLineSpan (getLoc func) = inci | ||
| | isOneLineSpan (getLoc func) = case unLoc func of | ||
| HsDo {} -> inciBy 2 | ||
| _ -> inci |
Collaborator
Author
There was a problem hiding this comment.
This worked in Ormolu because their indentation size is hardcoded to 2. It seems like for the case of a do-block in a one-line span, the indentation size should be exactly 2 (or 1 might work), regardless of the indentation setting
bf079c7 to
ae0deba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #114