This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Merged
Conversation
tasomaniac
commented
Mar 21, 2020
| import gherkin.ast.TableCell | ||
| import gherkin.ast.TableRow | ||
|
|
||
| internal fun Examples.toScenarios(outline: ScenarioOutline): List<Scenario> { |
Collaborator
Author
There was a problem hiding this comment.
New version of Cucumber is doing this Example to Scenario conversion during runtime.
I copied from old version. Thanks to Kotlin, it is pretty straight-forward.
fourlastor
approved these changes
Mar 21, 2020
Owner
fourlastor
left a comment
There was a problem hiding this comment.
All good, only one minor nitpick! Great work 🙏
| } | ||
|
|
||
| private fun ScenarioOutline.createExampleScenario(header: TableRow, example: TableRow): Scenario { | ||
| return Scenario( |
Owner
There was a problem hiding this comment.
quick return? I should put a linter
Collaborator
Author
There was a problem hiding this comment.
The project uses old Kotlin style which has 8 spaces indentation. I did quick return but it looked kind of ugly.
We should migrate to official style guide with 4 spaces.
Owner
There was a problem hiding this comment.
yeah, I'll change this in the future!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48