feat: allow other plugins to be composed with build#41
Merged
gakonst merged 1 commit intofoundry-rs:developfrom May 31, 2022
Merged
feat: allow other plugins to be composed with build#41gakonst merged 1 commit intofoundry-rs:developfrom
build#41gakonst merged 1 commit intofoundry-rs:developfrom
Conversation
🦋 Changeset detectedLatest commit: 141cbf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
I am observing this sort of working with typechain, it requires a hack for typechain should work with |
Call `runSuper` after compiling so that other plugins that hook into the `compile` task are still called. This will not work 100% with plugins that depend on the values that are returned by the actual hardhat compile task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
runSuperafter compiling so that other plugins that hook into thecompiletask are still called.I discovered that
hardhat/typechainwas not being ran with this plugin and I believe that this is the solution.Need to test locally to be sure. Note that calling
runSuperhere does not invoke the hardhat compilertoolchain. Two additional functions are added that I believe should be part of the
IArtifactsinterface but are not.Both of them are noops here, attempting to implement them would require a much larger change. Without them,
there is a
function is not definederror.Also delete some dead code in the constructor of
ForgeArtifacts