Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

test: add test empty config is sufficient#30

Merged
gakonst merged 3 commits intofoundry-rs:developfrom
mattsse:matt/add-anvil-default-network-test
May 30, 2022
Merged

test: add test empty config is sufficient#30
gakonst merged 3 commits intofoundry-rs:developfrom
mattsse:matt/add-anvil-default-network-test

Conversation

@mattsse
Copy link
Copy Markdown
Member

@mattsse mattsse commented May 19, 2022

add another test to ensure setting defaultNetwork = "anvil" is sufficient

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 19, 2022

⚠️ No Changeset found

Latest commit: c3d4c9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mattsse mattsse force-pushed the matt/add-anvil-default-network-test branch from 7541148 to c7558a6 Compare May 19, 2022 18:07
Copy link
Copy Markdown
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests seem to fail


const config: HardhatUserConfig = {
solidity: "0.7.3",
defaultNetwork: "anvil"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not require this at all? have the hardhat plugin do hre.config.defaultNetwork = "anvil" for the user?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works even without it because set when the plugin is initialised, removed in the fixture project to ensure it#s not required

@mattsse
Copy link
Copy Markdown
Member Author

mattsse commented May 24, 2022

no idea why checks are not running...

@mattsse mattsse changed the title test: add test setting defaultNetwork is sufficient test: add test empty config is sufficient May 24, 2022
@gakonst gakonst merged commit 09ae44e into foundry-rs:develop May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants