Skip to content

feat(coverage): exit early if tests failed#8268

Merged
mattsse merged 1 commit into
masterfrom
dani/coverage-exit
Jun 27, 2024
Merged

feat(coverage): exit early if tests failed#8268
mattsse merged 1 commit into
masterfrom
dani/coverage-exit

Conversation

@DaniPopes

Copy link
Copy Markdown
Member

Fixes #3900

@DaniPopes DaniPopes requested review from Evalir and mattsse as code owners June 27, 2024 09:43
@mattsse mattsse merged commit 67b1410 into master Jun 27, 2024
@mattsse mattsse deleted the dani/coverage-exit branch June 27, 2024 10:15
@grandizzy

Copy link
Copy Markdown
Collaborator

I am looking into changing this a little bit in order to fix #8014 (comment) The problem with current approach (collecting all test results and generating coverage report) for large codebases is that it requires bunch of mem to store results (in superform case more than 40G, which is OOMed in CI). Going to make a PR to stream result/process coverage report as it goes so hopefully large tests can be better accommodated (and also exit early if any failure), hope this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

forge coverage silently fails, showing zero coverage

3 participants