fix: smarter getCode validation#7597
Merged
Merged
Conversation
mattsse
requested changes
Apr 8, 2024
mattsse
left a comment
Member
There was a problem hiding this comment.
I see, this check makes sense to me,
can we add a test for this as well?
Member
Author
|
@mattsse created a separate profile for tests in multi-version environment |
Member
Author
|
As we're already here, also added more input options for vm.getCode("Counter.sol");
vm.getCode("Counter");
vm.getCode("Counter:0.X.X");
vm.getCode("Counter.sol:0.X.X");
vm.getCode("Counter.sol:Counter:0.X.X")` |
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
One more fix after #7334
If we've found multiple matching artifacts for
vm.getCodeand exactly one of them matches version of the currently running test/script source, return that.Ref https://t.me/foundry_support/52016
Solution
This changes test runner flow a bit so we now create executor for each
ContractRunnerto alter cheatcodes config with running contract version