Skip to content

chore(forge): kB to B in build --sizes#7588

Merged
DaniPopes merged 2 commits into
foundry-rs:masterfrom
kamuik16:kamuik16/7567
Apr 8, 2024
Merged

chore(forge): kB to B in build --sizes#7588
DaniPopes merged 2 commits into
foundry-rs:masterfrom
kamuik16:kamuik16/7567

Conversation

@kamuik16

@kamuik16 kamuik16 commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

Closes #7567

@kamuik16

kamuik16 commented Apr 7, 2024

Copy link
Copy Markdown
Contributor Author

Example Output:

Compiler run successful!
| Contract | Size (B) | Margin (B) |
|----------|----------|------------|
| Counter  | 247      | 24329      |

Comment thread crates/common/src/compile.rs Outdated
@onbjerg onbjerg self-assigned this Apr 8, 2024
@kamuik16 kamuik16 requested a review from onbjerg April 8, 2024 05:09

@Evalir Evalir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 5274799 into foundry-rs:master Apr 8, 2024
@kamuik16 kamuik16 deleted the kamuik16/7567 branch April 8, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] change forge build sizes report to Bytes

4 participants