Skip to content

feat(verify): multichain verification for etherscan#7537

Merged
mattsse merged 3 commits into
foundry-rs:masterfrom
yash-atreya:multi_chain_verification
Apr 2, 2024
Merged

feat(verify): multichain verification for etherscan#7537
mattsse merged 3 commits into
foundry-rs:masterfrom
yash-atreya:multi_chain_verification

Conversation

@yash-atreya

Copy link
Copy Markdown
Contributor

Motivation

Closes #7485

Solution

Incorporate the chain_id parameter while building etherscan client

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! pending errors

@yash-atreya

Copy link
Copy Markdown
Contributor Author

@mattsse Failing cargo deny due to open-ssl being banned. This occurs after updating to reqwest@0.12.2 and enabling the default-tls feature on it to use it here:

https://github.com/yash-atreya/foundry/blob/f686351921f0d666fa726b8420aa27d312c0e0d8/crates/config/src/etherscan.rs#L323

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no openssl

Comment thread crates/config/Cargo.toml Outdated
@yash-atreya yash-atreya requested a review from mattsse April 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Etherscan Multichain Contract Verification

2 participants