feat(anvil): Add memery limit to anvil node#7482
Merged
Merged
Conversation
mattsse
requested changes
Mar 25, 2024
mattsse
left a comment
Member
There was a problem hiding this comment.
great.
we shouldn't introduce new constants and instead use the revm defaults
Contributor
Author
ty very much for you review, does changes looks better for you ? |
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently anvil can running into error "EVM error MemoryLimitOOG" closes #7478
We add here a way to custom the memory limit for anvil node.
The default assigned here is 100 and can be changed if it's not the right default number.
EDIT: changed default value for memory-limit to 10000 after seeing all test related to anvil failling